e2e-test: Add build directive to libvirt code #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes confidential-containers#1701 The libvirt go modules require a local installation of libvirt, without it will fail to run: ```bash go test -c -tags=notlibvirt ./test/e2e /usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1 /usr/bin/ld: cannot find -lvirt-lxc /usr/bin/ld: cannot find -lvirt-lxc /usr/bin/ld: cannot find -lvirt-qemu /usr/bin/ld: cannot find -lvirt-qemu /usr/bin/ld: cannot find -lvirt collect2: error: ld returned 1 exit status ``` We shouldn't require libvirt to be present on a machine running kubernetes tests, hence the added directive to fix the test build: ``` go test -c -tags=notlibvirt ./test/e2e ``` Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
requested review from
wainersm,
surajssd,
bpradipt,
kartikjoshi21 and
stevenhorsman
stevenhorsman
approved these changes
Feb 20, 2024
mkulke
added
e2e-test
test_e2e_libvirt
surajssd
approved these changes
Feb 20, 2024
mkulke
deleted the
mkulke/add-build-directive-for-libvirt-code-in-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1701
The libvirt go modules require a local installation of libvirt, without it will fail to run:
We shouldn't require libvirt to be present on a machine running kubernetes tests, hence the added directive to fix the test build: