ci: refer to vars.AZURE_ACR_URL instead of secret #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes confidential-containers#1707 currently ACR_URL is set as secret and used as such in the workflow, however that prohibits passing the value as output. The workflow has been adjusted to use a repository variable for this value instead. the ACR_URL env is set globally in the worklflow and consumed in the jobs. drive-by fixes: - an outdated reference to secrets.AZURE_IMAGE_DEF_NAME - reference the build image workflow locally (not tied to the repo) Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/turn-acr_url-into-repo-variable-in-azure-e2e-test
branch
from
a01b106
to
de5f226
Compare
kartikjoshi21
approved these changes
Feb 22, 2024
surajssd
approved these changes
Feb 23, 2024
mkulke
deleted the
mkulke/turn-acr_url-into-repo-variable-in-azure-e2e-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1707
currently ACR_URL is set as secret and used as such in the workflow, however that prohibits passing the value as output. The workflow has been adjusted to use a repository variable for this value instead.
the ACR_URL env is set globally in the worklflow and consumed in the jobs.
drive-by fixes: