test-e2e: Make KBS opt-in for e2e tests #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change make KBS opt-in for e2e tests. For Azure provisioner opt-in for KBS installation. Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
mkulke
approved these changes
Mar 1, 2024
| KBS_IMAGE="${KBS_IMAGE}" | ||
| KBS_IMAGE_TAG="${KBS_IMAGE_TAG}" | ||
| DEPLOY_KBS="true" |
There was a problem hiding this comment.
This is fetched from shell env and not from properties file. Is it required to add it here ?
There was a problem hiding this comment.
Yes we can remove this, I confused this as a property coming from the properties file.
| shouldDeployKbs = false | ||
| shouldDeployKbs := false | ||
| if os.Getenv("DEPLOY_KBS") == "true" { | ||
| shouldDeployKbs = true |
There was a problem hiding this comment.
Also can we shift L121-L124 under this condition if shouldDeployKbs { on L138 ? It was shifted as part of review but i think we should move this condition down.
kartikjoshi21
force-pushed
the
make-kbs-opt-in
branch
from
789ec85
to
759609f
Compare
Validate kbs image and kbs image tag only when deploy kbs is enabled. Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21
force-pushed
the
make-kbs-opt-in
branch
from
759609f
to
3baefc7
Compare
|
govuln checks are addressed in #1728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change make KBS opt-in for e2e tests. For
Azure provisioner opt-in for KBS installation.