podvm: Fix podvm-binaries build #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
approved these changes
Mar 5, 2024
|
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/8160892320/job/22310210579?pr=1726 shows that the podvm image build is resolved in this issue. The tests didn't pass as they failed to get a runner, so back to the garm issue, but I think this is progress and worth merging. |
bpradipt
approved these changes
Mar 6, 2024
Nightly podvm-binaries build has been failing with: ``` 956.9 cd /src/cloud-api-adaptor/podvm/files/etc/kata-opa && ln -s -f "" default-policy.rego 956.9 ln: failed to create symbolic link 'default-policy.rego' -> '': No such file or directory ``` So port over the mkosi fix for this that Magnus did in confidential-containers#1718 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
podvm-binaries-default-agent-policy-fix
branch
from
f67faba
to
5c3071b
Compare
stevenhorsman
changed the title
|
Since I ran it last night govuln has updated and we need to bump to 1.21.8 now, so I've raised #1728 for this |
|
govuln checks are addressed under #1728 |
stevenhorsman
merged commit 06fc733
into
confidential-containers:main
25 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly podvm-binaries build has been failing with:
So port over the mkosi fix for this that Magnus did in #1718