-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peerpod-ctrl: Upgrade controller-tools version to latest v0.14.0 #1745
peerpod-ctrl: Upgrade controller-tools version to latest v0.14.0 #1745
Conversation
6871a41
to
2fc8343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit check is failing. I think this is due to the commit not having a body, so please add a description of what/why you are making this change. The controller and webhook CIs are also failing with go module issues. Please run make verify
on each of the changed components to test the errors locally.
2fc8343
to
015818b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ANJANA-A-R-K you need run make generate
for the three operator and commit the update files together.
go: downloading golang.org/x/text v0.14.0
/home/runner/work/cloud-api-adaptor/cloud-api-adaptor/peerpodconfig-ctrl/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
diff --git a/peerpodconfig-ctrl/api/v1alpha1/zz_generated.deepcopy.go b/peerpodconfig-ctrl/api/v1alpha1/zz_generated.deepcopy.go
index e604c10..0846d9e 100644
--- a/peerpodconfig-ctrl/api/v1alpha1/zz_generated.deepcopy.go
+++ b/peerpodconfig-ctrl/api/v1alpha1/zz_generated.deepcopy.go
@@ -1,5 +1,4 @@
//go:build !ignore_autogenerated
-// +build !ignore_autogenerated
/*
Copyright Confidential Containers Contributors
make: *** [Makefile:202: verify-gen] Error 1
generated files are out of date, run make generate
Error: Process completed with exit code 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ANJANA-A-R-K
@ANJANA-A-R-K - can you |
Upgrade controller-tools version from v0.10.0 to latest v0.14.0 Fixes: confidential-containers#1744 Signed-off-by: ANJANA-A-R-K1 <anjana.a.r.k1@ibm.com>
fed3238
to
ef85533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Fixes: #1744
peerpod-ctrl is deployed with
make deploy
on s390x