libvirt: Improve the setup instructions to run libvirt tests #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @ldoktor these change are good to me, as we change the repo in a new files structure, would you like rebase this PR with main branch. |
The Create the Kubernetes cluster is duplicate as the same steps are already executed under `config_libvirt`. Also improve some wording and examples here and there to ensure the workflow works well out of the box (tested on Fedora 38). Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
link those files together to simplify the life of newcomers. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
the 120s timeout is quite short and frequently fails on my network. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Let's run all example commands from the main "cloud-api-adaptor" folder (unless it's required, then use pushd/popd explicitely). Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
|
Sure, changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few things that should simplify the setup for the newcomers