Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: fix the bad workflows after we are in new file structure #1757

Merged
merged 1 commit into from
Mar 22, 2024
Merged

workflow: fix the bad workflows after we are in new file structure #1757

merged 1 commit into from
Mar 22, 2024

Conversation

liudalibj
Copy link
Member

@liudalibj liudalibj commented Mar 22, 2024 •
edited

  • fix bad docker images build for test images
  • the context and file need be set correctly when using docker/build-push-action
  • also fix the e2e-test failed at Installing peerpod-ctrl

fixes for:

@liudalibj liudalibj added the test_e2e_libvirt Run Libvirt e2e tests label Mar 22, 2024
@liudalibj
Copy link
Member Author

add test_e2e_libvert label to run/verify Libvirt e2e tests too.

@liudalibj liudalibj removed the test_e2e_libvirt Run Libvirt e2e tests label Mar 22, 2024
@liudalibj
workflow: fix test-images and podvm_mkosi
c345487 
- fix bad docker images build for test images
- try to fix podvm_mkosi build
- fix e2e-test `Installing peerpod-ctrl`

Signed-off-by: Da Li Liu <liudali@cn.ibm.com>
@liudalibj liudalibj changed the title workflow: test-images.yaml workflow: fix the bad workflows after we are in new file structure Mar 22, 2024
@liudalibj liudalibj added the test_e2e_libvirt Run Libvirt e2e tests label Mar 22, 2024
huoqifeng
huoqifeng approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @liudalibj

@huoqifeng huoqifeng merged commit 7796bee into confidential-containers:main Mar 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huoqifeng huoqifeng huoqifeng approved these changes

@genjuro214 genjuro214 genjuro214 approved these changes

@stevenhorsman stevenhorsman Awaiting requested review from stevenhorsman

Assignees
No one assigned
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liudalibj @huoqifeng @genjuro214