Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodFailing scenario: updated assessment_runner.go #1761

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

chathuryaadapa
Copy link
Contributor

Added code to handle the pod fail scenario by cross checking the error message we pass in .WithFailReason(reason string)

Fixes: #1760

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Mar 28, 2024
@stevenhorsman
Copy link
Member

The commit message check is failing as your commit header should start with tests/e2e and be 50 chars long.
I think you can also squash the commits together as they are all tightly related.
Let me know if you hit any problems with this. Thanks!

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested it locally, and don't know the specific cases that failed, but I ran the libvirt e2e tests and it passes still and the code looks ok

Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liudalibj
Copy link
Member

@chathuryaadapa would you like squash the commits together? after that we are ready to merge this PR.

Added code to handle the pod fail scenario by cross checking the error message we pass in .WithFailReason(reason string)

fixes: confidential-containers#1760
Signed-off-by: Adapa Chathurya <adapa.chathurya1@ibm.com>
@liudalibj liudalibj removed the test_e2e_libvirt Run Libvirt e2e tests label Apr 2, 2024
@liudalibj liudalibj merged commit 6063583 into confidential-containers:main Apr 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling the podFailing scenarios
4 participants