podvm-mkosi: fix Architecture cannot be used in [Match] #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkosi version in nix is 17.1, which doesn't support Architecture in [Match] As a workaround, use a flag files instead Signed-off-by: Lei Li <genjuro214@gmail.com> Signed-off-by: Lei Li <cdlleili@cn.ibm.com>
|
As we discussed on the meeting yesterday, we'll try to get this PR reviewed and merged for 0.8.1 release to fix the x86 problem. And we'll create a new issue to align the approach for s390x and x86. @liudalibj @genjuro214 @stevenhorsman @bpradipt |
huoqifeng
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
LGTM, thanks @genjuro214
I don't have a env to test it but I think it's OK to use:
PathExists=... instead Architecture in [March] because Architecture is not supported in mkosi introduced in nix 17.1 while the image built via latest nix does not work either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build x86 podvm image with mkosi, we may hit following error:
We depend on nix to setup mkosi build environment. Current mkosi version in nix is
17.1:According to the v17.1 doc, Architecture in [Match] has not been supported in this version:
https://github.com/systemd/mkosi/blob/v17.1/mkosi/resources/mkosi.md
If upgrading mkosi version in nix, we may hit some other new errors. So I'd like to keep mkosi version and use flag files instead to fix the Architecture error.