azure: Comment out service principal env file #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service principal env file was needed when we used to rely on using service principal and its secrets. But we have moved away from using SP and now we use managed identities. So, we don't need this file anymore. But if someone needs it they still have a reference, so this commit comments it out, instead of removing it altogether. Also another problem with this is that the CI runs fail as this file does not exists and kustomize errors out. In the CI run we don't provide the kustomization file we modify the existing kustomization file. Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service principal env file was needed when we used to rely on using service principal and its secrets. But we have moved away from using SP and now we use managed identities. So, we don't need this file anymore. But if someone needs it they still have a reference, so this commit comments it out, instead of removing it altogether.
Also another problem with this is that the CI runs fail as this file does not exists and kustomize errors out. In the CI run we don't provide the kustomization file we modify the existing kustomization file.