Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update build.sh #1774

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

davidhadas
Copy link
Member

@davidhadas davidhadas commented Apr 7, 2024

podman does not support a --push flag.

Replaces #1739

@davidhadas davidhadas force-pushed the buildSh branch 2 times, most recently from 6748552 to 3f5a2e4 Compare April 9, 2024 18:11
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bpradipt bpradipt requested review from beraldoleal, huoqifeng and stevenhorsman and removed request for beraldoleal April 10, 2024 07:06
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Thanks

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Update build.sh to support podman
podman does not support the --push flag

Signed-off-by: David Hadas <david.hadas@gmail.com>
@liudalibj liudalibj merged commit f1fd4d9 into confidential-containers:main Apr 12, 2024
18 checks passed
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenhorsman stevenhorsman mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants