cloud-api-adaptor: Set dnsPolicy to ClusterFirstWithHostNet #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhadas
force-pushed
the
DnsPolicy2
branch
2 times, most recently
from
f44286d
to
22dc011
Compare
bpradipt
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
/lgtm
@davidhadas can you please update the commit message with this reference mentioning about the correct dnsPolicy setting when hostNetwork: true https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/
snir911
approved these changes
Apr 10, 2024
change dns setting of the CAA daemonset's pod-spec name: cloud-api-adaptor-daemonset namespace: confidential-containers-system The correct dnsPolicy setting when hostNetwork: true is dnsPolicy: ClusterFirstWithHostNet See https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/ Signed-off-by: David Hadas <david.hadas@gmail.com>
stevenhorsman
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change dns setting of the CAA daemonset's pod-spec
name: cloud-api-adaptor-daemonset
namespace: confidential-containers-system
Should use
dnsPolicy: ClusterFirstWithHostNet