-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt: deploy kbs for libvirt provider in e2e test #1778
Conversation
|
Fixes: confidential-containers#1777 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks reasonable and the instructions and output you've provided seem to work. I do wonder if we need to document them (noteable where to check out trustee to and the DEPLOY_KBS
flag and options) in the e2e README, but I appreciate that you didn't add these, so I'm not sure if should block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @stevenhorsman , We still have some gaps to provide a e2e guide besides deploying KBS, I'll add the guide when have the TEE enabled pod running. |
Fixes: #1777