Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-api-adaptor: remove checksum from Dockerfile #1781

Merged

Conversation

davidhadas
Copy link
Member

Podman does not yet support checksum
containers/buildah#5135

Podman does not yet support checksum
containers/buildah#5135

Signed-off-by: David Hadas <david.hadas@gmail.com>
@davidhadas
Copy link
Member Author

@mkulke @stevenhorsman ^^ - related to earlier slack discussion.

Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a RUN statement that verifies the checksum?

Add `RUN echo "${YQ_CHECKSUM#sha256:} /usr/local/bin/yq" | sha256sum -c`
to checksum yq

Signed-off-by: David Hadas <david.hadas@gmail.com>
Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @davidhadas

@stevenhorsman stevenhorsman merged commit ab394a7 into confidential-containers:main Apr 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants