Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix working dir for azure e2e test #1784

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Apr 8, 2024

Since the project's folders have been reorgarnized the workflow needs an adjusted directories.

Successful run on a fork: https://github.com/mkulke/cloud-api-adaptor/actions/runs/8614880290

@mkulke mkulke marked this pull request as draft April 8, 2024 17:50
@mkulke
Copy link
Contributor Author

mkulke commented Apr 8, 2024

we probably cannot set this globally, since there are steps that depend on the WD to be ./ needs further debugging

- service-principal has been commented out, we don't need a dummy file
  anymore for azure
- the artifact path for the ssh key was wrong

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>

wip

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/change-workingdir-for-azure-e2e-test branch from 31aa0fd to cbb724b Compare April 9, 2024 11:14
@mkulke
Copy link
Contributor Author

mkulke commented Apr 9, 2024

ok, figured it out, the artifact's was not adjusted

@mkulke mkulke closed this Apr 9, 2024
@mkulke mkulke reopened this Apr 9, 2024
@mkulke mkulke marked this pull request as ready for review April 9, 2024 11:50
@kartikjoshi21 kartikjoshi21 merged commit 25b3436 into confidential-containers:main Apr 10, 2024
35 checks passed
@mkulke mkulke deleted the mkulke/change-workingdir-for-azure-e2e-test branch April 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants