Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Build: Update build.sh" #1793

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Revert "Build: Update build.sh" #1793

merged 1 commit into from
Apr 12, 2024

Conversation

stevenhorsman
Copy link
Member

This reverts commit f1fd4d9.

Fixes: #1792

@stevenhorsman
Revert "Build: Update build.sh"
d5ab4ca 
This reverts commit f1fd4d9.

Fixes: confidential-containers#1792
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
beraldoleal
beraldoleal approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@portersrc
Copy link
Member

lgtm

wainersm
wainersm approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems that we still need to push to ${registry}/${name}

@stevenhorsman
Copy link
Member Author

LGTM. It seems that we still need to push to ${registry}/${name}

I think it might be part of the tag_string (with the -t removed) rather than ${registry}/${name} as that wasn't created by the buildx step before

@stevenhorsman stevenhorsman merged commit d73a884 into confidential-containers:main Apr 12, 2024
18 checks passed
@stevenhorsman stevenhorsman deleted the revert-1774 branch April 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beraldoleal beraldoleal beraldoleal approved these changes

@wainersm wainersm wainersm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert #1774
4 participants
@stevenhorsman @portersrc @beraldoleal @wainersm