Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add condition for kbs deploy in provisioner to align with e2e test #1796

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

huoqifeng
Copy link
Contributor

@huoqifeng huoqifeng commented Apr 15, 2024

Fixes: #1777

@huoqifeng huoqifeng force-pushed the provisioner branch 3 times, most recently from bd13d66 to 888de52 Compare April 15, 2024 07:04
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @huoqifeng!

Fixes: confidential-containers#1777

Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
Copy link
Contributor

@kartikjoshi21 kartikjoshi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @huoqifeng

@huoqifeng huoqifeng marked this pull request as ready for review April 15, 2024 08:54
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartikjoshi21 kartikjoshi21 merged commit 89e19f5 into confidential-containers:main Apr 15, 2024
18 checks passed
@stevenhorsman
Copy link
Member

This was reverted in #1800, so will need re-applying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy kbs for libvirt e2e test
4 participants