Workflows: fix release workflow #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release workflow should follow the push workflow and use the sample-kbc for the SIM payload Signed-off-by: Tobin Feldman-Fitzthum <tobin@ibm.com>
dcmiddle
approved these changes
Jun 7, 2023
26 tasks
Xynnn007
approved these changes
Jun 8, 2023
|
I've been offline this week so I can only comment after the fact. This change is mostly cosmetic and not necessary for the release since we dropped eaa-kbc. KBC in the bundle name is a leftover and likely going away from the push workflow too. We rely on sample_kbc being enabled by default in AA. With this change the problem with the release is that SIM bundle does not have cc-kbc enabled. HW has both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should the release workflow match the push workflow? Currently we are releasing a
SIM-cc-kbcbundle, which does not match our CI bundles. Is this necessary?@Xynnn007 @mythi @dcmiddle