config: Add max_concurrent_download for pull operation #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::thread::available_parallelism() will get available cpu num in host side for enclave-cc, export the config for enclave/kata agent to decide. DEFAULT_MAX_CONCURRENT_DOWNLOAD is set to 3 which is the same default config for dockerd. Signed-off-by: Wang, Arron <arron.wang@intel.com>
arronwy
requested review from
sameo,
jiangliu,
lumjjb,
jialez0 and
Xynnn007
as code owners
mythi
approved these changes
May 25, 2023
There was a problem hiding this comment.
Looks good to me and tested with:
-image-rs = { git = "https://github.com/confidential-containers/image-rs.git", default-features = false, rev = "44f27c2" }
+image-rs = { git = "https://github.com/arronwy/image-rs.git", default-features = false, branch = "config" }
in enclave-cc and it helps to fix an image pull that was failing earlier.
2 tasks
Xynnn007
approved these changes
May 25, 2023
dcmiddle
pushed a commit
to dcmiddle/guest-components
that referenced
this pull request
Jun 5, 2023
This commit fixes KEK registration for keyprovider to KBS. Including address parse, key generation and indexing Close confidential-containers#153 Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::thread::available_parallelism()will get all available cpu num in host side for enclave-cc, export the config for enclave/kata agent to decide.Thanks @mythi for point this out.
DEFAULT_MAX_CONCURRENT_DOWNLOAD is set to 3 which is the same default config for dockerd.