Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: quick start guide of cosign image signing #87

Merged
merged 1 commit into from
Jan 4, 2023
Merged

docs: quick start guide of cosign image signing #87

merged 1 commit into from
Jan 4, 2023

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Dec 2, 2022

Signed-off-by: Xynnn007 xynnn@linux.alibaba.com

@Xynnn007
Copy link
Member Author

This error seems not related to this PR. We can fix it in another PR.


## Signing the encrypted/unencrypted image and enable signature verification when running the workload

When an image is from a protected registry, the image needs to be applied some defined security strategies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just linking Steve's review for this section for readability.
https://github.com/confidential-containers/documentation/pull/65/files#r1025358425

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, have fixed it

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xynnn007 , LGTM!

@arronwy arronwy merged commit 668bf36 into confidential-containers:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants