add Dockerfile for reproducible build
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you please reuse https://github.com/confidential-containers/td-shim/blob/main/devtools/dev_container/Dockerfile, as much as possible? |
gaojiaqi7
force-pushed
the
0926/docker_reproducible
branch
from
3348742
to
9f0cdfe
Compare
jyao1
reviewed
Oct 9, 2023
| @@ -37,3 +37,6 @@ RUN set -eux; \ | |||
| git clone https://github.com/sslab-gatech/Rudra.git; \ | |||
| cd Rudra; \ | |||
| ./install-release.sh; | |||
|
|
|||
| RUN git clone https://github.com/confidential-containers/td-shim.git | |||
There was a problem hiding this comment.
@jiangliu , are you OK with that change?
The reproducibility of td-shim is limited by the same system user and source code path, so we can use Docker container to reproduce binaries. Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
gaojiaqi7
force-pushed
the
0926/docker_reproducible
branch
from
9f0cdfe
to
8ce4afb
Compare
jyao1
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reproducibility of td-shim is limited by the same system user and source code path, so we can use a Docker container to reproduce binaries.
Resolves: #604