Merge pull request #5 from config-files-api/better_inspect

Better inspect

.rubocop.yml

@@ -49,3 +49,7 @@ Style/RegexpLiteral:
 # Easier recognization if access modified used
 Style/AccessModifierIndentation:
   EnforcedStyle: outdent
+
+# method_alias is safer and more predictable
+Style/Alias:
+  EnforcedStyle: prefer_alias_method

CHANGELOG

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Tue May 24 13:24:15 UTC 2016 - jreidinger@suse.com
+
+- better inspecting of BooleanValue objects (helps with debugging
+  various bncs, like bnc#980108 or bnc#940465)
+- 0.3.1
+
 -------------------------------------------------------------------
 Mon Dec 21 13:29:54 UTC 2015 - jreidinger@suse.com
 

cfa.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = "cfa"
-  s.version     = "0.3.0"
+  s.version     = "0.3.1"
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Josef Reidinger"]
   s.email       = ["jreidinger@suse.cz"]

lib/cfa/base_model.rb

@@ -156,6 +156,16 @@ def value=(value)
       @model.generic_set(@name, value ? @true_value : @false_value)
     end
 
+    # enhanced inspect method to contain important data
+    def inspect
+      "#<CFA::BooleanValue:0x#{object_id} name=#{@name.inspect}, " \
+        "data=#{data.inspect}, true_value=#{@true_value.inspect}, " \
+        "false_value=#{@false_value.inspect}>"
+    end
+
+    # also have better to_s
+    alias_method :to_s, :inspect
+
   private
 
     def data

lib/cfa/matcher.rb

@@ -9,7 +9,7 @@ def initialize(key: nil, collection: nil, value_matcher: nil, &block)
         return false unless key_match?(element, key)
         return false unless collection_match?(element, collection)
         return false unless value_match?(element, value_matcher)
-        return false unless !block || block.call(element[:key], element[:value])
+        return false unless !block || yield(element[:key], element[:value])
         return true
       end
     end