Fix deletion of augeas elements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid remove all when nil is passed
jreidinger
reviewed
Dec 5, 2016
| @@ -1,4 +1,10 @@ | |||
| ------------------------------------------------------------------- | |||
| Mon Dec 5 15:38:36 UTC 2016 - joseivanlopez@gmail.com | |||
|
|
|||
| - fix deletion of augeas elements | |||
There was a problem hiding this comment.
id is needed, you can reuse bsc from previous changelog entry
There was a problem hiding this comment.
and please be more verbose in changes. Maybe something like fix regression when passing nil to AugeasTree#delete
joseivanlopez
force-pushed
the
fix_delete
branch
from
58d866d
to
d8dac9f
Compare
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nil is passed to AugeasTree#delete, all elements are removed. Fix method to control when nil is passed.
#13 (comment)