-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default file handler #3
Conversation
@@ -1,4 +1,10 @@ | |||
------------------------------------------------------------------- | |||
Mon Dec 21 13:29:54 UTC 2015 - jreidinger@suse.com | |||
|
|||
- allow specify default file handler all models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow specifying a default file handler for all models
Just a NP (and English correction by Martin). In sort, LGTM. |
def initialize(parser, file_path, file_handler: File) | ||
@file_handler = file_handler | ||
# `write(string, string)`. For example see {CFA::MemoryFile}. When nil | ||
# passed it use object from default_file_handler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Yardoc link to the method + grammar fixes:
# @param file_handler [.read, .write] an object able to read/write a string.
# It has to provide methods `string read(string)` and
# `write(string, string)`. For an example see {CFA::MemoryFile}.
# If unspecified or `nil`, {.default_file_handler} is asked.
No description provided.