Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix usage of 'traditional' instead of 'usual' for function adam #220

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

MonikaZimmermann
Copy link
Contributor

While examining the code for the adam function in adam.R, I discovered that it is implemented with the parameter 'bounds=c("usual","admissible","none")'. However, in the documentation for the bounds parameter '@param bounds', bounds are described as '...traditional - restricting the values within (0, 1)...'.

In the 'adamGeneral.R' file, bounds are implemented as 'bounds=c("traditional","usual","admissible","none")'. However, when bounds="traditional", line 2483 'bounds <- match.arg(bounds,c("usual","admissible","none"))' throws an error.

Additionally, while reviewing the examples in 'adam.Rmd', 'traditional' was used once more, where 'usual' would provide better clarity.

@config-i1
Copy link
Owner

Thanks for spotting that! I think I left it half way through, forgetting to implement the options properly (there are several: https://openforecast.org/adam/ETSParametersBounds.html - only two are supported by ADAM).

@config-i1 config-i1 merged commit 44bf5fe into config-i1:master Apr 24, 2024
3 checks passed
@MonikaZimmermann
Copy link
Contributor Author

You are welcome! Thank you for providing the link to your book. I worked with it a lot in the past months and really like the intuitive explanations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants