Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'Add()' to 'Set()' #92

Closed
adamralph opened this issue Oct 25, 2013 · 1 comment
Closed

Change 'Add()' to 'Set()' #92

adamralph opened this issue Oct 25, 2013 · 1 comment
Labels
invalid

Comments

@adamralph
Copy link
Contributor

May make more sense and, given the changes introduced in #70, it may be a good idea to force current consumers to update their scripts, making it clear that they should now use the local Set() rather than Configurator.Set() in order to have source info plus the possibility for isolating configs.
@adamralph
Copy link
Contributor Author

Bad idea - Set() has write many times semantics. Add() has write once semantics. We want the latter.

@adamralph adamralph mentioned this issue Nov 30, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamralph