-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolated config scripts #70
Comments
Need to preserve static addition - this is useful for communicating values from app to script, e.g. version, which can be used to execute versioned config. The best idea is probably to always implicitly ensure a basic configurator is present to receive statically added values. This means statically added values will always have no 'source', they just come from code somewhere. This is probably OK. When adding values through scripts the new local Add() method should be used which will convey source info and ensure that the items belong to the current configurator when using isolated scripts. |
too messy and not worth it |
#70 reinstated static addition for PassingAValueFromAnAppToAConfigurationScript
Allows things like:
Currently there is no way to get a handle on the 'current' configurator in script. We only have a handle to the static
Configurator
which represents the latest configurator in the cascade chain, as controlled byConfigurator.Load();
.The new syntax will allow the following in script:
I.e. no reference to the static
Configurator
when adding. This adds the value to the current configurator. If the configurator is loaded via a call to one of the staticConfigurator.Load()
methods then its values still form part of the cascading values.It will still be possible to read values in script using the
Configurator.Get()
methods. Of course, it will also still be possible to add values usingConfigurator.Add()
in script, but this would be pathological.The text was updated successfully, but these errors were encountered: