Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kotlin.text.Regex #63

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

roxspring
Copy link
Contributor

  • Added support for kotlin Regex class since they appear often in configuration

@codecov-io
Copy link

codecov-io commented Oct 3, 2018

Codecov Report

Merging #63 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #63     +/-   ##
===========================================
+ Coverage     74.39%   74.69%   +0.3%     
- Complexity       46       48      +2     
===========================================
  Files            22       23      +1     
  Lines           164      166      +2     
  Branches         72       73      +1     
===========================================
+ Hits            122      124      +2     
  Misses           20       20             
  Partials         22       22
Impacted Files Coverage Δ Complexity Δ
...rc/main/io.github.config4k/readers/SelectReader.kt 100% <100%> (ø) 27 <0> (+1) ⬆️
src/main/io.github.config4k/readers/RegexReader.kt 100% <100%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b9207...fc6d7da. Read the comment docs.

Copy link
Contributor

@mmorihiro mmorihiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants