Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct clientReady hook in Auto Poll mode #94

Merged
merged 3 commits into from Nov 9, 2023
Merged

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Oct 9, 2023

Describe the purpose of your pull request

So far the clientReady event has fired in Auto Poll mode only when receiving 200, 304, 403 or 404 status code. In other cases (including the case of network errors) maxInitWaitTime has been waited before firing clientReady.

Breaking changes:

  • Change the behavior of the clientReady hook to fire after the completion of the first fetch operation in Auto Poll mode - regardless of success or failure - to make the behavior consistent with other SDKs.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner October 9, 2023 15:01
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3687e95) 91.63% compared to head (5bd8ce6) 91.75%.
Report is 2 commits behind head on master.

❗ Current head 5bd8ce6 differs from pull request most recent head d5d2b55. Consider uploading reports for the commit d5d2b55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   91.63%   91.75%   +0.12%     
==========================================
  Files          18       18              
  Lines        1613     1613              
  Branches      406      408       +2     
==========================================
+ Hits         1478     1480       +2     
+ Misses        134      132       -2     
  Partials        1        1              
Files Coverage Δ
src/AutoPollConfigService.ts 96.77% <100.00%> (-0.04%) ⬇️
src/ConfigServiceBase.ts 89.93% <100.00%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…xInitWaitTime is zero (maxInitWaitTime should take precedence over cache sync-up)
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adams85 adams85 merged commit 2b8f955 into master Nov 9, 2023
14 checks passed
@adams85 adams85 deleted the fix/clientready-hook branch November 9, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants