-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use import type
instead of import
while importing types
#262
Conversation
@DarhkVoyd Thanks for working on this issue. Your contribution is really appreciated. |
import type
instead of import
while importing types
@DarhkVoyd as disscussed at the Discord, please add the rule to the .eslint config file - Line 22 in 6e19a42
then commit the change, then run cd ts; npm run lint , then see if you have some diff it means you missed some places, then if everything works great commit again and push and then it will be merged :) thanks
|
@rannn505 I have added the required rule to .eslint config file. I also doubled checked by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @DarhkVoyd, we really appreciate your contribution and we can't wait to see your future involvement in our community ⭐ ⭐
@RichardAkman Thank you! Could you please merge this PR? |
Hi @DarhkVoyd , check out the #266 (comment) for details regarding the Hacktoberfest rewards |
Description
This PR addresses an issue where TypeScript files earlier used the
import
syntax instead of the more specificimport type
. Theimport type
syntax in TypeScript is used to import only the types from a module, rather than the entire module which can be useful for quite a few reasons.Key Changes:
import type
syntax.Resolves: #207