Implement eval command to upsert command piping #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardAkman
requested review from
rannn505 and
RonConfigu
and removed request for
rannn505
4 tasks
RonConfigu
reviewed
Oct 31, 2023
rannn505
reviewed
Nov 1, 2023
rannn505
reviewed
Nov 1, 2023
rannn505
reviewed
Nov 1, 2023
rannn505
reviewed
Nov 1, 2023
| errorScope, | ||
| ); | ||
| } | ||
| if (_.isEmpty(configs) && _.isEmpty(pipe)) { |
There was a problem hiding this comment.
why not sppliting it via wach one of the loops?
There was a problem hiding this comment.
I don't understand the question. This condition is to skip the async init method in case there is nothing to upsert.
rannn505
reviewed
Nov 1, 2023
| const upsertConfigs = _(configs) | ||
| .entries() | ||
| .map<Config>(([key, value]) => { | ||
| this.validateConfigValue({ key, value, skipDeclarationAndTemplateValidation: false }); |
There was a problem hiding this comment.
I would convert the whole mapper function here
There was a problem hiding this comment.
split the skip flag to each of the validation
There was a problem hiding this comment.
I split the validations. I don't understand what "convert the whole mapper function here" means.. please elaborate.
rannn505
requested changes
Nov 1, 2023
rannn505
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the TS upsert command API to support piping of an eval command result to an upsert command.
pipethat is a result of an eval command. If provided, the eval result is merged together with the provided configs (which take priority over an eval result). Any key that does not belong to the schema received in the upsert command is filtered, same goes for any key that is a template in the provided schema.pipeparameter by also having their relevant parameters renamed topipe(breaking change), the affected code and docs have been adjusted accordingly.falseas a value does not get validated due to an erroneous condition.Notes: