Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configu cli next #324

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Configu cli next #324

merged 1 commit into from
Dec 11, 2023

Conversation

rannn505
Copy link
Contributor

@rannn505 rannn505 commented Dec 11, 2023 •
edited

  • upgrade oclif to v3
  • upgrade all cli deps
  • upgrade configu sdk - use the new schema syntax with a wrapper getSchemaInstanceBySchemaFlag
  • allow yaml schema (experimental)
  • upgrade cosmiconfig major v9 - searchStrategy
  • extract common functions as utils
  • add launch-darkly, cloud-bees to cli store dict
  • add pipe to upsert
  • fix upsert --import fails on extra/missing keys from schema
  • fix run command cwd - allow customize, default to .configu location
  • init - allow override name always even on premade schemas
  • init - new initial state "some key/value"

Closes #247
Closes #297

@rannn505
cli next
b41c131 
- upgrade oclif to v3
- upgrade all cli deps
- upgrade configu sdk - use the new schema syntax with a wrapper getSchemaInstanceBySchemaFlag
- allow yaml schema (experimental)
- upgrade cosmiconfig major v9 - searchStrategy
- extract common functions as utils
- add `launch-darkly`, `cloud-bees` to cli store dict
- add pipe to upsert
- fix upsert --import fails on extra/missing keys from schema
- fix run command cwd - allow customize, default to .configu location
- init - allow override name always even on premade schemas
- init - new initial state "some key/value"
@rannn505 rannn505 added feat New feature or request @configu/py labels Dec 11, 2023
@rannn505 rannn505 self-assigned this Dec 11, 2023
@rannn505 rannn505 requested a review from a team as a code owner December 11, 2023 01:00
@rannn505 rannn505 merged commit fec9094 into main Dec 11, 2023
6 of 7 checks passed
@rannn505 rannn505 deleted the 0-cli-upgrade-oclif-major-3 branch December 11, 2023 01:06
RichardAkman
RichardAkman reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@RichardAkman RichardAkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the upsert command piping works well and I also played around with the YAML schema format which looks solid. I haven't looked too deep into the new OClif major version, I assume you verified that there are no breaking changes.

@RichardAkman RichardAkman mentioned this pull request Mar 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardAkman RichardAkman RichardAkman left review comments

Assignees

@rannn505 rannn505

Labels
@configu/cli feat New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@rannn505 @RichardAkman