Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pipeMode Parameter to EvalCommand #346

Closed
wants to merge 13 commits into from
Closed

Implement pipeMode Parameter to EvalCommand #346

wants to merge 13 commits into from

Commits on Jan 18, 2024

  1. Add pipeMode Parameter to EvalCommand

    @ShriekinNinja
    ShriekinNinja committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    838c9a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. - [x] Create Test Units

    @ShriekinNinja
    ShriekinNinja committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2c38d09 View commit details
    Browse the repository at this point in the history

  2. - [x] Create type EvalCommandPipeMode = 'include' | 'forward' - Nam… 

    …ing TBD @rannn505

- [x] Add `pipeMode?: EvalCommandPipeMode` to `EvalCommandParameters`
- [x] Add `pipeMode` to `EvalCommandReturn[KEY]['context']` so that the next `EvalCommand` could identify which to remove
- [x] Modify `EvalCommand.run()` to add the new context.pipeMode to its configs. *currently on the ones from the schema. Q.1 answer may change it to override piped configs context.pipeMode*
- [x] Create Test Units
    @ShriekinNinja
    ShriekinNinja committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fdec0b3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 336-Add-pipeMode-Parameter-to-EvalCommand

    @ShriekinNinja
    ShriekinNinja committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bb94b94 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. - CR I Comments

    @ShriekinNinja
    ShriekinNinja committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    444149c View commit details
    Browse the repository at this point in the history

  2. Update ts/packages/ts/src/commands/commands.test.ts 

    Co-authored-by: Richard Akman <richard.akman1@gmail.com>
    @RonConfigu @RichardAkman
    RonConfigu and RichardAkman committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b5576ff View commit details
    Browse the repository at this point in the history

  3. Update ts/packages/ts/src/commands/commands.test.ts 

    Co-authored-by: Richard Akman <richard.akman1@gmail.com>
    @RonConfigu @RichardAkman
    RonConfigu and RichardAkman committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cac8e58 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/336-Add-pipeMode-Parameter-to-Ev… 

    …alCommand' into 336-Add-pipeMode-Parameter-to-EvalCommand
    @ShriekinNinja
    ShriekinNinja committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3202da9 View commit details
    Browse the repository at this point in the history

  5. Update ts/packages/ts/src/commands/commands.test.ts 

    Co-authored-by: Richard Akman <richard.akman1@gmail.com>
    @RonConfigu @RichardAkman
    RonConfigu and RichardAkman committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    38039fd View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/336-Add-pipeMode-Parameter-to-Ev… 

    …alCommand' into 336-Add-pipeMode-Parameter-to-EvalCommand
    @ShriekinNinja
    ShriekinNinja committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f39b91c View commit details
    Browse the repository at this point in the history

  7. - CR I Comments

    @ShriekinNinja
    ShriekinNinja committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cea77d1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into 336-Add-pipeMode-Parameter-to-EvalCommand

    @ShriekinNinja
    ShriekinNinja committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e040476 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. # CR I Comments 

    - Tests
    @ShriekinNinja
    ShriekinNinja committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    48fd41a View commit details
    Browse the repository at this point in the history