Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format objects for terraform .tfvars file #395

Conversation

idanela
Copy link
Contributor

@idanela idanela commented Mar 13, 2024

When coverting to .tfvars files the code ignored the possibility that value could be an object.
Therefore, terraform did not considered it valid because it was converted to a string that contains the object.
I added a check to determine rather it is an object or not, and if so it ommited the quotation marks.

Solves #377

@idanela idanela requested a review from a team as a code owner March 13, 2024 12:25
@RichardAkman RichardAkman linked an issue Mar 13, 2024 that may be closed by this pull request
@RichardAkman RichardAkman added the bug Something isn't working label Mar 13, 2024
@idanela idanela changed the title 377 format objects for terraform .tfvars file Format objects for terraform .tfvars file Mar 13, 2024
@RichardAkman RichardAkman linked an issue Mar 13, 2024 that may be closed by this pull request
@rannn505
Copy link
Contributor

@RichardAkman can you review?

Copy link
Contributor

@RichardAkman RichardAkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ⭐ 🏅

I've made a slight adjustment to the formatter strategy to ensure that the function always correctly identifies object strings.

@RichardAkman RichardAkman merged commit ed5947b into configu:main Apr 14, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community @configu/lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format objects for Terraform .tfvars file
3 participants