Load OC address with query #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
LGTM.
Two improvement ideas:
- Add
src/codecto.eslintignoreto speed up linting. They are ignored at file level already, but if you can avoid reading all the files in the folder, this is even better. - Ensure
src/codecruns through prettier only once after codegen. Thenyarn formatshould ignore this folder for performance reasons.
scripts/proto/get-proto.sh
Outdated
| # TODO: get automatically from tgrade repo | ||
| # Create a "tgrade" folder with "confio" and "third_party" subfolders. | ||
| # "confio" contents come from: https://github.com/confio/tgrade/tree/main/proto/confio | ||
| # third_party contents come from: https://github.com/confio/tgrade/tree/main/third_party |
There was a problem hiding this comment.
Nice breaking down of tasks to get unblocked! This scripting stuff can burn hours quickly.
HannuProd
approved these changes
Nov 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189