Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tMarket.test.ts - part#1 #437

Merged
merged 5 commits into from
Feb 28, 2022
Merged

tMarket.test.ts - part#1 #437

merged 5 commits into from
Feb 28, 2022

Conversation

Ebazhanov
Copy link
Contributor

This PR about writing first part of tMarket.test.ts tests

Copy link
Collaborator

@abefernan abefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

],
undefined,
undefined,
tcContractAddress,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why do you test with Trusted Token instead of CW20? Maybe we should test them separately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, replaced to CW20
as discussed we could do testing with Trusted token in https://github.com/confio/tgrade-app/blob/main/src/__tests__/integration/in-development/tMarketTrustedCircle.test.ts

Comment on lines 65 to 67
undefined,
undefined,
tcContractAddress,
undefined,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove these lines. If the last parameter(s) of a function call is undefined you can omit it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Ebazhanov Ebazhanov merged commit 8a232dd into 0.6 Feb 28, 2022
@Ebazhanov Ebazhanov deleted the t-market-tests-part-1 branch February 28, 2022 10:09
Ebazhanov added a commit that referenced this pull request Feb 28, 2022
@Ebazhanov Ebazhanov mentioned this pull request Feb 28, 2022
@@ -3,10 +3,9 @@ import { Bech32 } from "@cosmjs/encoding";
import { DirectSecp256k1HdWallet } from "@cosmjs/proto-signing";
import { makeCosmoshubPath } from "@cosmjs/stargate";
import { config } from "config/network";
import { OcContract } from "utils/oversightCommunity";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you use OcContract for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw your comment, those changes is not related to tMarket tests, it is just improvements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is created


  const oC = await OcCommunity.propose(address, comment, {
    add_voting_members: {
      voters: [memberToAdd],
    },
  });

in `oversightCommunityContract.test.ts

Ebazhanov added a commit that referenced this pull request Feb 28, 2022
@Ebazhanov Ebazhanov linked an issue Feb 28, 2022 that may be closed by this pull request
1 task
@Ebazhanov Ebazhanov removed a link to an issue Feb 28, 2022
1 task
maurolacy pushed a commit that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants