-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tMarket.test.ts - part#1 #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
], | ||
undefined, | ||
undefined, | ||
tcContractAddress, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why do you test with Trusted Token instead of CW20? Maybe we should test them separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, replaced to CW20
as discussed we could do testing with Trusted token in https://github.com/confio/tgrade-app/blob/main/src/__tests__/integration/in-development/tMarketTrustedCircle.test.ts
undefined, | ||
undefined, | ||
tcContractAddress, | ||
undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove these lines. If the last parameter(s) of a function call is undefined you can omit it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -3,10 +3,9 @@ import { Bech32 } from "@cosmjs/encoding"; | |||
import { DirectSecp256k1HdWallet } from "@cosmjs/proto-signing"; | |||
import { makeCosmoshubPath } from "@cosmjs/stargate"; | |||
import { config } from "config/network"; | |||
import { OcContract } from "utils/oversightCommunity"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you use OcContract for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saw your comment, those changes is not related to tMarket tests, it is just improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is created
const oC = await OcCommunity.propose(address, comment, {
add_voting_members: {
voters: [memberToAdd],
},
});
in `oversightCommunityContract.test.ts
This PR about writing first part of tMarket.test.ts tests