Make GA dependant on cookieyes #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abefernan
commented
Mar 7, 2022
| <!-- Start Google Analytics for dapp.tgrade.finance only --> | ||
| <script | ||
| async | ||
| data-cookieyes="cookieyes-analytics" |
There was a problem hiding this comment.
I added this data-* attribute following this: https://www.cookieyes.com/implement-prior-consent-using-cookieyes
The rest is just reorder of <link>s at the top and <script>s at the end.
@abefernan for Chrome, Safari looks good but in Firefox the behavior is different original behavior Chrome After ✅ Firefox 🔴 Safari ✅ |
Ebazhanov
previously requested changes
Mar 7, 2022
|
My firefox fails for some bad usage on cookieyes part: |
do you know if we have requirements to make it work across different browsers? if not I am fine to approve |
abefernan
dismissed
Ebazhanov’s stale review
Extracted firefox bug to another ticket #468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #420