Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "Engagement" tests (part#2) #504

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Implement "Engagement" tests (part#2) #504

merged 4 commits into from
Mar 22, 2022

Conversation

Ebazhanov
Copy link
Contributor

@Ebazhanov Ebazhanov commented Mar 21, 2022 •
edited

This PR about implementing Engagement tests, some of them is disabled due to dependency from each other which we are going to fix after next release of Tgrade, more info here https://confio.slack.com/archives/C033TBY03NJ/p1647872982179439

  • Claim my own rewards and send them to another address
  • Set another account as my delegate
  • As a delegate, claim rewards from an account that has chosen me as delegate
  • As a delegate, claim rewards from an account that has chosen me as delegate and send them to another address

@Ebazhanov Ebazhanov marked this pull request as draft March 21, 2022 09:51
@Ebazhanov Ebazhanov changed the title Draft Engagement tests part#2, first attempt Implement "Engagement" tests (part#2) Mar 22, 2022
@Ebazhanov Ebazhanov linked an issue Mar 22, 2022 that may be closed by this pull request
Implement "Engagement" tests (part#2) #502
Closed
4 tasks
@Ebazhanov Ebazhanov added the Integration tests Integration tests label Mar 22, 2022
@Ebazhanov Ebazhanov marked this pull request as ready for review March 22, 2022 09:33
abefernan
abefernan approved these changes Mar 22, 2022
View reviewed changes
src/__tests__/integration/happy-paths/engagement.test.ts Outdated
@@ -73,6 +74,7 @@ describe("Engagement", () => {

// Before Withdraw Rewards step
const withdrawableRewardsBefore = await egContract.getWithdrawableRewards(userWallet);
jest.setTimeout(150000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, I think I forgot to remove (did some experimenting)
ok will remove it

@Ebazhanov Ebazhanov merged commit ba3d2aa into main Mar 22, 2022
@Ebazhanov Ebazhanov deleted the engagment-tests-part-2 branch March 22, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abefernan abefernan abefernan approved these changes

@HannuProd HannuProd Awaiting requested review from HannuProd

Assignees
No one assigned
Labels
Integration tests Integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "Engagement" tests (part#2)
2 participants
@Ebazhanov @abefernan