Information message if user clicks Try the Tgrade App (Desktop only) using "Mobile" devices
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ebazhanov
changed the title
Try the Tgrade App (Desktop only) using "Mobile" devices
Ebazhanov
changed the title
Try the Tgrade App (Desktop only) using "Mobile" devicesTry the Tgrade App (Desktop only) using "Mobile" devices
HannuProd
reviewed
Mar 23, 2022
src/App/index.tsx
Outdated
| @@ -21,57 +23,71 @@ const Engagement = lazy(() => import("./pages/Engagement")); | |||
| const OcHome = lazy(() => import("./pages/OcHome")); | |||
| const TMarketHome = lazy(() => import("App/pages/TMarket")); | |||
|
|
|||
| export const WarningMessage = styled.h1` | |||
There was a problem hiding this comment.
Nice! but please move this to components as a component and then import it
There was a problem hiding this comment.
thanks, done bd9b710
please let me know if I have to use different name for folder like 'TextAlert' or ...
There was a problem hiding this comment.
Well technically it is a informationMessage now when you ask
HannuProd
reviewed
Mar 23, 2022
| @@ -0,0 +1,10 @@ | |||
| import styled from "styled-components"; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Please remove this comment
There was a problem hiding this comment.
done, thx
3823aee
Ebazhanov
changed the title
Try the Tgrade App (Desktop only) using "Mobile" devicesTry the Tgrade App (Desktop only) using "Mobile" devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR about adding warning message for the moment when user trying to start using 'Tgrade App' on mobile devices
(fyi we are waiting for design based on this ticket https://github.com/confio/design/issues/52)
Test scenarios when user click 'Try the Tgrade App (Desktop only)' button:
screencast.2022-03-23.14-56-00.mp4