Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unfocus when typing #523

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Fix unfocus when typing #523

merged 2 commits into from
Mar 25, 2022

Conversation

abefernan
Copy link
Collaborator

Closes #477.

@abefernan abefernan self-assigned this Mar 24, 2022
Ebazhanov
Ebazhanov approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@Ebazhanov Ebazhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @abefernan so the problem was with useCallback and re rendering after each type action [controlledProps, onInputChange, onTextAreaChange, textArea],

Ebazhanov
Ebazhanov reviewed Mar 24, 2022
View reviewed changes
src/App/components/Field/index.tsx
{...props}
onChange={onTextAreaChange}
showCount
maxLength={500}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a question do we really need so many 500 symbols?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just following the design in figma

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi i asked Kain if it is should be like this, to double check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Daniella is the PO for tgrade
  2. No reason to ask, we decide how we implement things

@abefernan abefernan marked this pull request as ready for review March 25, 2022 07:41
@abefernan abefernan merged commit 55c8a28 into main Mar 25, 2022
@abefernan abefernan deleted the fix-type-unfocus branch March 25, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ebazhanov Ebazhanov Ebazhanov approved these changes

@HannuProd HannuProd HannuProd approved these changes

Assignees

@abefernan abefernan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user can't type&delete more then one characters in the field
3 participants
@abefernan @Ebazhanov @HannuProd