-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize docker-compose for orchestrating the example cluster. #25
Conversation
It looks like @tkaemming hasn't signed our Contributor License Agreement, yet. Appreciation of efforts, clabot |
@tkaemming Sir i edit the Dockerfile.client to build my custom client
i can successfully build image like this |
@wanghaisheng I'm not exactly sure what that has to do with this pull request, but you're missing a connection password that is required for whatever database you're attempting to connect to. There are a bunch of ways to fix this, mounting a As an aside for the maintainer(s), with regard to the CLA message above: I'm perfectly happy to sign it, but I'm not sure where to do so. |
@tkaemming thx for your point, after a little dig into the source code ,I figure out it "--postgres" param format could be "postgres://user:pass@host:port/dbname " it works now |
Hi @tkaemming, the @ConfluentCLABot used to provide more details about the CLA, and you can find instructions for reading the CLA (and eventually signing it) in this comment. |
|
||
You can run `docker logs bottledwater` to see what it's doing. Now Bottled Water has taken | ||
You can run `docker-compose logs bottledwater` to see what it's doing. Now Bottled Water has taken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkaemming I used the docker-compose'd demo yesterday, following the instructions that you updated in the README
.
(I think that using Docker Compose actually does simplify the demo, and that the docker-compose.yml
file does help understanding how the pieces are linked together. That's great!)
Also, I noticed something I think may be an error:
(sudo) docker-compose logs bottledwater
raises the following error:Error response from daemon: no such id: bottledwater
(sudo) docker-compose logs bottledwaterpg_bottledwater_run_1
, on the other hand, prints the logs as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting… I don't get an error as you do trying to get the logs — however, I don't get any log output, either! Interrogating the container directly via docker logs
works, as does docker bottledwaterpg_bottledwater_run_1
.
In either case, I suppose docker-compose up -d bottledwater
would be more appropriate than docker-compose run
here and that also fixes the log issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes a lot of sense @tkaemming !
[clabot:check] |
@confluentinc It looks like @tkaemming just signed our Contributor License Agreement. 👍 Always at your service, clabot |
This starts it as a service, rather than a one-off command, which is more appropriate, and enables easier access to log output, etc.
Closing, as this has been supplanted by #62. |
@tkaemming Hi, I was in a hurry yesterday, but wanted to say thanks for your work on this! Hope you don't mind that I ended up reimplementing it. I did make an effort to compare them and see if I could build on top of your branch instead of redoing from scratch, but that proved tricky due to a combination of bitrot and superficial differences, and I have another large PR about to land that depends on my version. You definitely led the way here though. |
No problem — happy to see the project continuing to move forward! |
This makes it a bit easier to start and stop (and destroy) the linked containers for the test environment, and makes the user-defined flags such as
--topic
a bit more obvious, since they're not alongside the networking topology flags like--link
.Also, it should also be possible to use the build attribute to build the
confluent/bottledwater:0.1
andconfluent/postgres-bw:0.1
images (for thebottledwater
andpostgres
services, respectively) from the local repository, rather than pulling from Docker Hub. This would make it a little bit easier to hack on the internals, since you would not have to repeatedly build and tag new images independently during development. I'd be happy to take the time to adjust the buildDockerfiles
to make that work, if you're interested.