Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1097 Fix table header for connect plugin list #1006

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

MuweiHe
Copy link
Contributor

@MuweiHe MuweiHe commented Sep 17, 2021

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Added PluginHumanFields in connect cmds to fix the output header of connect plugin list from "PluginName" to "Plugin Name".

References

Test&Review

@MuweiHe MuweiHe requested a review from a team as a code owner September 17, 2021 21:27
@MuweiHe MuweiHe changed the base branch from master to 2.0 September 17, 2021 21:27
@brianstrauch
Copy link
Member

Do we have an integration test?

@MuweiHe
Copy link
Contributor Author

MuweiHe commented Sep 17, 2021

Do we have an integration test?

Yes, in TestConnectPlugin, the golden file has been updated accordingly.

@brianstrauch
Copy link
Member

@MuweiHe Can we change the base branch to main instead?

@MuweiHe MuweiHe changed the base branch from 2.0 to master September 17, 2021 22:29
Copy link
Member

@brianstrauch brianstrauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main, not master! 😬

@MuweiHe MuweiHe changed the base branch from master to 2.0 September 17, 2021 22:32
@MuweiHe MuweiHe changed the base branch from 2.0 to main September 17, 2021 22:34
@MuweiHe
Copy link
Contributor Author

MuweiHe commented Sep 17, 2021

main, not master! 😬

got it!

@MuweiHe MuweiHe merged commit a98b5b5 into main Sep 17, 2021
@MuweiHe MuweiHe deleted the CLI-1097-2.0 branch September 17, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants