Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Unification: Fix release errors #1025

Merged
merged 3 commits into from
Sep 29, 2021
Merged

CLI Unification: Fix release errors #1025

merged 3 commits into from
Sep 29, 2021

Conversation

brianstrauch
Copy link
Member

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Fixes for a few errors I ran into while releasing the unified CLI.

@brianstrauch brianstrauch requested a review from a team as a code owner September 28, 2021 20:35
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is impossible to catch all these the first time 😥

@brianstrauch brianstrauch merged commit 0a5c703 into main Sep 29, 2021
@brianstrauch brianstrauch deleted the fix-release-errors branch September 29, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants