Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1374: Show service account resource ID in audit-log describe and connect event describe #1055

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

brianstrauch
Copy link
Member

@brianstrauch brianstrauch commented Oct 28, 2021

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Show the resource ID instead of the internal ID for both commands. Note: In the future, we might want to call the top command confluent audit-log event describe for uniformity.

$ confluent audit-log describe      
+-----------------+----------------------------+
| Cluster         | lkc-q82z76                 |
| Environment     | env-1270xz                 |
| Service Account | sa-7y0od2                  |
| Topic Name      | confluent-audit-log-events |
+-----------------+----------------------------+
$ confluent connect event describe 
+-----------------+------------------------------+
| Cluster         | lkc-q82z76                   |
| Environment     | env-1270xz                   |
| Service Account | sa-7y0od2                    |
| Topic Name      | confluent-connect-log-events |
+-----------------+------------------------------+

References

CLI-1374
Requires https://github.com/confluentinc/ccloud-sdk-go-v1/pull/159

Test & Review

Updated all tests

@brianstrauch brianstrauch requested a review from a team as a code owner October 28, 2021 20:30
@brianstrauch brianstrauch merged commit 619b6e0 into main Nov 2, 2021
@brianstrauch brianstrauch deleted the CLI-1374 branch November 2, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants