[RCCA-4684] ignore errors getting user profile when listing invitations #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+91
to
+92
| FirstName: firstName, | ||
| LastName: lastName, |
There was a problem hiding this comment.
So if there's an error, it's going to add a row with a missing first and last name? Is that intended?
There was a problem hiding this comment.
correct - which is fine since a user that has not accepted the invite yet (error case) would not yet have a first name / last name associated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
issue was that there was a GetUserProfile request being made to retrieve the first and last name of users to populate the invitation list. However, for users that have not yet accepted the invite via email, this request fails with
User not found. The fix is to ignore errors on the GetUserProfile request and in that case just populate first/last names with "".References
https://confluentinc.atlassian.net/browse/RCCA-4684
Test&Review
maunally