Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code-only examples & HTTP method cleanup #1133

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

brianstrauch
Copy link
Member

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Miscellaneous fixes:

  • Replace all instances of "GET", "POST", etc. with http.MethodGet, http.MethodPost, etc.
  • Remove unused .goreleaser-fake.yml file
  • Use cmd for root command & remove unnecessary DisableAutoGenTag field.
  • Fix example output when there is no text

Test & Review

Before:

Examples:
Resume a connector in the current or specified Kafka cluster context.

  $ confluent connect resume --config config.json



  $ confluent connect resume --config config.json --cluster lkc-123456

After:

Examples:
Resume a connector in the current or specified Kafka cluster context.

  $ confluent connect resume --config config.json

  $ confluent connect resume --config config.json --cluster lkc-123456

@brianstrauch brianstrauch requested a review from a team as a code owner December 15, 2021 21:26
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quality improvements!

@brianstrauch
Copy link
Member Author

Schema registry is still failing to build in Muckrake. Merging...

@brianstrauch brianstrauch merged commit 17d4b9c into main Dec 16, 2021
@brianstrauch brianstrauch deleted the misc-improvements branch December 16, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants