Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion: confluent kafka #1136

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Autocompletion: confluent kafka #1136

merged 5 commits into from
Dec 16, 2021

Conversation

brianstrauch
Copy link
Member

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok

  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Autocompletion for kafka cluster, kafka consumer-group, and kafka topic. Autocompletion for --cluster coming next.

% confluent kafka cluster describe lkc-<TAB>
lkc-j8r3dw  lkc-kg5p0p

% confluent kafka topic describe topic-<TAB>
topic-1  topic-2

@brianstrauch brianstrauch requested a review from a team as a code owner December 16, 2021 01:43
DABH
DABH approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianstrauch
Copy link
Member Author

Schema registry is still failing to build in Muckrake. Merging...

@brianstrauch brianstrauch merged commit 17c7353 into main Dec 16, 2021
@brianstrauch brianstrauch deleted the ac-kafka branch December 16, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianstrauch @DABH