Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KFS-1863] add local mode to flink shell #2713

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

YannickPferr
Copy link
Member

Checklist

  • Leave this box unchecked if features are not yet available in production

What

This adds two flags behind a feature flag which will only be enabled for internal orgs. With these flags we can overwrite the ApplicationOptions the shell uses. This enables us to run the flink shell with a local instance of the Flink system.

References

Test & Review

This adds two flags behind a feature flag which will only be enabled for internal orgs. With these flags we can overwrite the ApplicationOptions the shell uses. This enables us to run the flink shell with a local instance of the Flink system.
@YannickPferr YannickPferr requested review from a team as code owners April 15, 2024 18:14
@YannickPferr YannickPferr changed the title feat: add local mode to CLI [KFS-1863] add local mode to CLI Apr 15, 2024
@YannickPferr YannickPferr changed the title [KFS-1863] add local mode to CLI [KFS-1863] add local mode to flink shell Apr 15, 2024
internal/flink/command_shell.go Outdated Show resolved Hide resolved
internal/flink/command_shell.go Outdated Show resolved Hide resolved
internal/flink/command_shell.go Outdated Show resolved Hide resolved
pkg/flink/app/application.go Outdated Show resolved Hide resolved
pkg/flink/app/application.go Outdated Show resolved Hide resolved
internal/flink/command_shell.go Outdated Show resolved Hide resolved
internal/flink/command_shell.go Outdated Show resolved Hide resolved
pkg/flink/lsp/lsp_completer_ws.go Outdated Show resolved Hide resolved
@YannickPferr YannickPferr enabled auto-merge (squash) April 17, 2024 07:40
@YannickPferr YannickPferr merged commit c243317 into main Apr 17, 2024
3 checks passed
@YannickPferr YannickPferr deleted the feat/KFS-1863-add-gateway-url-flag branch April 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants