-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-997: removes all usages of user.organization_id throught the CLI #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm when CI passes
go.mod
Outdated
@@ -24,7 +26,7 @@ require ( | |||
github.com/confluentinc/cc-structs/kafka/util v0.753.0 | |||
github.com/confluentinc/cc-structs/operator v0.753.0 | |||
github.com/confluentinc/cc-utils-public v0.1.0 | |||
github.com/confluentinc/ccloud-sdk-go-v1 v0.0.79 | |||
github.com/confluentinc/ccloud-sdk-go-v1 v0.0.79-0.20210616223458-373e540901a7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? Looks like this might be reason for the test failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, it is to pull in my dependent ccloud-sdk-go PR here https://github.com/confluentinc/ccloud-sdk-go-v1/pull/147 I wanted to run the ccloud-sdk-go changes through the CLI CI jobs before merging it. I will update the version here though before merging the CLI PR.
go.mod
Outdated
github.com/google/gofuzz v1.1.0 // indirect | ||
github.com/google/uuid v1.2.0 | ||
github.com/goreleaser/goreleaser v0.162.1 | ||
github.com/goreleaser/goreleaser v0.169.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DABH Is a golreleaser bump ok? Idk i can't remember if this has caused issues in the past
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we should probably just keep it the same if possible. It takes a few extra changes to really upgrade the version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah did not mean to bump that up. I did run go get goreleaser
which must have bumped the version
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
We are deprecating user.organization_id in favor of organization.id, which should always be fetched from the auth context or explicitly passed in via parameters. This is for project nexus's initiative to support multiple users per org--we can no longer assume a user belongs to only one org, therefore we cannot rely on the
user.organization_id
field anymore.References
Test&Review
I built this locally with a version of cc-structs that does not have user.organization_id defined and found all the places where that field is referenced and replaced them with organization.id, or removed the user.organization_id entirely, since in almost all our APIs the organization id is read from the jwt token and not from explicitly api parameters.
gonna wait for the ci jobs to pass, since this does not introduce any new logic, we just want to avoid regressions