CLI-967 Maybe: ‘kafka cluster describe` should not reveal the Kafka API endpoint #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianstrauch
approved these changes
Jul 21, 2021
|
I wonder if merging this into |
right.... Think we can manually edit the status of the ticket? |
MuweiHe
added a commit
that referenced
this pull request
Jul 26, 2021
MuweiHe
added a commit
that referenced
this pull request
Jul 26, 2021
MuweiHe
added a commit
that referenced
this pull request
Aug 11, 2021
…PI endpoint (#932) * not expose api endpoint in cluster describe * Update command_cluster_cloud_test.go
MuweiHe
added a commit
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
No longer expose API endpoint in
kafka cluster describecommands. Kafka API is not a customer facing supported thing, so we should remove the "ApiEndpoint" field from this list.References
Maybe: ‘kafka cluster describe` should not reveal the Kafka API endpoint
Test&Review